Commit d09008a
deps: V8: cherry-pick 1a3ecc2483b2
Original commit message:
Fix build issue, remove unneeded include uchar.h.
Follow the conversation on:
https://groups.google.com/g/v8-dev/c/nsbshwlmP3c.
The `uchar.h` include is not necessary.
It was added to get the definition of char16_t but that's an intrinsic
type in C++.
Change-Id: I0aaa11dba0be3ccad15b9e421f8bae71450d443b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4823404
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Cr-Commit-Position: refs/heads/main@{#89787}
Refs: v8/v8@1a3ecc2
PR-URL: #49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #58342
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent fd56652 commit d09008a
4 files changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.28', | ||
| 39 | + 'v8_embedder_string': '-node.29', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -188,6 +188,7 @@ Matt Hanselman <mjhanselman@gmail.com> | |||
| 188 | 188 | Matthew Sporleder <msporleder@gmail.com> | |
| 189 | 189 | Maxim Mazurok <maxim@mazurok.com> | |
| 190 | 190 | Maxim Mossienko <maxim.mossienko@gmail.com> | |
| 191 | + Meir Shpilraien <meir@redis.com> | ||
| 191 | 192 | Michael Lutz <michi@icosahedron.de> | |
| 192 | 193 | Michael Mclaughlin <m8ch88l@gmail.com> | |
| 193 | 194 | Michael Smith <mike@w3.org> | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,7 +6,6 @@ | |||
| 6 | 6 | #define V8_INSPECTOR_STRING_16_H_ | |
| 7 | 7 | ||
| 8 | 8 | #include <stdint.h> | |
| 9 | - #include <uchar.h> | ||
| 10 | 9 | ||
| 11 | 10 | #include <cctype> | |
| 12 | 11 | #include <climits> | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,7 +5,6 @@ | |||
| 5 | 5 | #ifndef V8_INSPECTOR_V8_STRING_CONVERSIONS_H_ | |
| 6 | 6 | #define V8_INSPECTOR_V8_STRING_CONVERSIONS_H_ | |
| 7 | 7 | ||
| 8 | - #include <uchar.h> | ||
| 9 | 8 | ||
| 10 | 9 | #include <cstdint> | |
| 11 | 10 | #include <string> | |
0 commit comments