Commit d0ad873
src: prevent changing FunctionTemplateInfo after publish
Refs https://chromium-review.googlesource.com/c/v8/v8/+/2718147
Fixes an issue where Node.js tries to call SetClassName on a
FunctionTemplate twice in some cases. The above CL made it so that
V8 CHECKs when this occurs. It is fixed by ensuring SetClassName
is only called once.
PR-URL: #46979
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 7283486 commit d0ad873
2 files changed
Lines changed: 11 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -340,8 +340,11 @@ void HistogramBase::RegisterExternalReferences( | |||
| 340 | 340 | } | |
| 341 | 341 | ||
| 342 | 342 | void HistogramBase::Initialize(Environment* env, Local<Object> target) { | |
| 343 | - SetConstructorFunction( | ||
| 344 | - env->context(), target, "Histogram", GetConstructorTemplate(env)); | ||
| 343 | + SetConstructorFunction(env->context(), | ||
| 344 | + target, | ||
| 345 | + "Histogram", | ||
| 346 | + GetConstructorTemplate(env), | ||
| 347 | + SetConstructorFunctionFlag::NONE); | ||
| 345 | 348 | } | |
| 346 | 349 | ||
| 347 | 350 | BaseObjectPtr<BaseObject> HistogramBase::HistogramTransferData::Deserialize( | |
@@ -367,6 +370,7 @@ Local<FunctionTemplate> IntervalHistogram::GetConstructorTemplate( | |||
| 367 | 370 | Isolate* isolate = env->isolate(); | |
| 368 | 371 | tmpl = NewFunctionTemplate(isolate, nullptr); | |
| 369 | 372 | tmpl->Inherit(HandleWrap::GetConstructorTemplate(env)); | |
| 373 | + tmpl->SetClassName(OneByteString(isolate, "Histogram")); | ||
| 370 | 374 | tmpl->InstanceTemplate()->SetInternalFieldCount( | |
| 371 | 375 | HistogramBase::kInternalFieldCount); | |
| 372 | 376 | SetProtoMethodNoSideEffect(isolate, tmpl, "count", GetCount); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1495,13 +1495,16 @@ static void InitMessaging(Local<Object> target, | |||
| 1495 | 1495 | t->Inherit(BaseObject::GetConstructorTemplate(env)); | |
| 1496 | 1496 | t->InstanceTemplate()->SetInternalFieldCount( | |
| 1497 | 1497 | JSTransferable::kInternalFieldCount); | |
| 1498 | - SetConstructorFunction(context, target, "JSTransferable", t); | ||
| 1498 | + t->SetClassName(OneByteString(isolate, "JSTransferable")); | ||
| 1499 | + SetConstructorFunction( | ||
| 1500 | + context, target, "JSTransferable", t, SetConstructorFunctionFlag::NONE); | ||
| 1499 | 1501 | } | |
| 1500 | 1502 | ||
| 1501 | 1503 | SetConstructorFunction(context, | |
| 1502 | 1504 | target, | |
| 1503 | 1505 | env->message_port_constructor_string(), | |
| 1504 | - GetMessagePortConstructorTemplate(env)); | ||
| 1506 | + GetMessagePortConstructorTemplate(env), | ||
| 1507 | + SetConstructorFunctionFlag::NONE); | ||
| 1505 | 1508 | ||
| 1506 | 1509 | // These are not methods on the MessagePort prototype, because | |
| 1507 | 1510 | // the browser equivalents do not provide them. | |
0 commit comments