fixup! readline: fix unicode line separators being ignored · nodejs/node@d0b4c39 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 639
• Pull requests 564
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d0b4c39

Browse filesBrowse the repository at this point in the historyBrowse files

dario-piotrowicz

committed

fixup! readline: fix unicode line separators being ignored

remove confising comparison with regexp splits

1 parent a5b3e45 commit d0b4c39
Copy full SHA for d0b4c39

1 file changed

+1-3Lines changed: 1 addition & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-readline-line-separators.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-readline-line-separators.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-readline-line-separators.js

+1-3Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -14,7 +14,5 @@ const linesRead = [];
14	14	rli.on('line', (line) => linesRead.push(line));
15	15
16	16	rli.on('close', common.mustCall(() => {
17		- const regexpLines = str.split(/^/m).map((line) => line.trim()).filter(Boolean);
18		- // Readline interprets different lines in the same way js regular expressions do
19		- assert.deepStrictEqual(linesRead, regexpLines);
	17	+ assert.deepStrictEqual(linesRead, ['012', '345', '67', '89', 'ABC', 'DEF']);
20	18	}));

0 commit comments

Comments

0 (0)