Commit d0b8959
deps: use proper C standard when building libuv
Upstream libuv commits:
libuv/libuv@bb706f5
libuv/libuv@018363a
libuv was updated to 1.51.0 in 0315283.
v1.51.0 was the release updating from c90 to c11.
The standard was back then also updated from c89 to c90. and C89 was
never an official standard to begin with. So, I wonder how this managed
to stay without breaking anyone's builds for this long. This atleast
breaks the builds for Android using NDK r28b and r28a, as LLONG_MAX is
not defined by the Clang compiler for older C standards.
Fixes:
../../deps/uv/src/unix/linux.c:2331:36:
error: use of undeclared identifier 'LLONG_MAX'
2331 | constraint->quota_per_period = LLONG_MAX;
| ^
1 error generated.
PR-URL: #58587
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent fcef56c commit d0b8959
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -190,7 +190,7 @@ | |||
| 190 | 190 | '-Wno-unused-parameter', | |
| 191 | 191 | '-Wstrict-prototypes', | |
| 192 | 192 | ], | |
| 193 | - 'OTHER_CFLAGS': [ '-g', '--std=gnu89' ], | ||
| 193 | + 'OTHER_CFLAGS': [ '-g', '--std=gnu11' ], | ||
| 194 | 194 | }, | |
| 195 | 195 | 'conditions': [ | |
| 196 | 196 | [ 'OS=="win"', { | |
@@ -262,7 +262,7 @@ | |||
| 262 | 262 | 'cflags': [ | |
| 263 | 263 | '-fvisibility=hidden', | |
| 264 | 264 | '-g', | |
| 265 | - '--std=gnu89', | ||
| 265 | + '--std=gnu11', | ||
| 266 | 266 | '-Wall', | |
| 267 | 267 | '-Wextra', | |
| 268 | 268 | '-Wno-unused-parameter', | |
0 commit comments