Commit d0f68a3
test: deflake test-common-expect-warning
The subprocess might exit before the data is flushed. Run the assertion
after the `'end'` event is emitted.
PR-URL: #42046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent f107f8b commit d0f68a3
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,9 +36,11 @@ if (process.argv[2] !== 'child') { | |||
| 36 | 36 | child.stderr.on('data', (data) => { | |
| 37 | 37 | stderr += data; | |
| 38 | 38 | }); | |
| 39 | + child.stderr.on('end', common.mustCall(() => { | ||
| 40 | + assert.match(stderr, /Unexpected extra warning received/); | ||
| 41 | + })); | ||
| 39 | 42 | child.on('exit', common.mustCall((status) => { | |
| 40 | 43 | assert.notStrictEqual(status, 0); | |
| 41 | - assert.match(stderr, /Unexpected extra warning received/); | ||
| 42 | 44 | })); | |
| 43 | 45 | } | |
| 44 | 46 | } else { | |
0 commit comments