FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: use Ubuntu 24.04 and Clang on GitHub actions · nodejs/node@d18a67f · GitHub

/ node Public

Commit d18a67f

Browse files
authored and
marco-ippolito
committed
tools: use Ubuntu 24.04 and Clang on GitHub actions
This puts us closer to what V8 actively supports. GCC is still covered a lot by Jenkins CI. Co-authored-by: Moshe Atlow <moshe@atlow.co.il> PR-URL: #53212 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
1 parent 292d13a commit d18a67f

6 files changed

Lines changed: 32 additions & 22 deletions

File tree

‎.github/workflows/build-tarball.yml‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,17 @@ concurrency:
3030
env:
3131
PYTHON_VERSION: '3.12'
3232
FLAKY_TESTS: keep_retrying
33+
CC: sccache clang
34+
CXX: sccache clang++
35+
SCCACHE_GHA_ENABLED: 'true'
3336

3437
permissions:
3538
contents: read
3639

3740
jobs:
3841
build-tarball:
3942
if: github.event.pull_request.draft == false
40-
runs-on: ubuntu-latest
43+
runs-on: ubuntu-24.04
4144
steps:
4245
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
4346
with:
@@ -46,6 +49,10 @@ jobs:
4649
uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
4750
with:
4851
python-version: ${{ env.PYTHON_VERSION }}
52+
- name: Set up sccache
53+
uses: mozilla-actions/sccache-action@2e7f9ec7921547d4b46598398ca573513895d0bd # v0.0.4
54+
with:
55+
version: v0.8.0
4956
- name: Environment Information
5057
run: npx envinfo
5158
- name: Make tarball
@@ -63,7 +70,7 @@ jobs:
6370
path: tarballs
6471
test-tarball-linux:
6572
needs: build-tarball
66-
runs-on: ubuntu-latest
73+
runs-on: ubuntu-24.04
6774
steps:
6875
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
6976
with:
@@ -72,6 +79,10 @@ jobs:
7279
uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
7380
with:
7481
python-version: ${{ env.PYTHON_VERSION }}
82+
- name: Set up sccache
83+
uses: mozilla-actions/sccache-action@2e7f9ec7921547d4b46598398ca573513895d0bd # v0.0.4
84+
with:
85+
version: v0.8.0
7586
- name: Environment Information
7687
run: npx envinfo
7788
- name: Download tarball

‎.github/workflows/coverage-linux-without-intl.yml‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,17 @@ concurrency:
3232
env:
3333
PYTHON_VERSION: '3.12'
3434
FLAKY_TESTS: keep_retrying
35+
CC: sccache clang
36+
CXX: sccache clang++
37+
SCCACHE_GHA_ENABLED: 'true'
3538

3639
permissions:
3740
contents: read
3841

3942
jobs:
4043
coverage-linux-without-intl:
4144
if: github.event.pull_request.draft == false
42-
runs-on: ubuntu-latest
43-
env:
44-
CC: sccache gcc
45-
CXX: sccache g++
46-
SCCACHE_GHA_ENABLED: 'true'
45+
runs-on: ubuntu-24.04
4746
steps:
4847
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
4948
with:

‎.github/workflows/coverage-linux.yml‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,17 @@ concurrency:
3232
env:
3333
PYTHON_VERSION: '3.12'
3434
FLAKY_TESTS: keep_retrying
35+
CC: sccache clang
36+
CXX: sccache clang++
37+
SCCACHE_GHA_ENABLED: 'true'
3538

3639
permissions:
3740
contents: read
3841

3942
jobs:
4043
coverage-linux:
4144
if: github.event.pull_request.draft == false
42-
runs-on: ubuntu-latest
43-
env:
44-
CC: sccache gcc
45-
CXX: sccache g++
46-
SCCACHE_GHA_ENABLED: 'true'
45+
runs-on: ubuntu-24.04
4746
steps:
4847
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
4948
with:

‎.github/workflows/daily.yml‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ permissions:
1313

1414
jobs:
1515
build-lto:
16-
runs-on: ubuntu-latest
17-
# not working on gcc-8 and gcc-9 see https://github.com/nodejs/node/issues/38570
18-
container: gcc:11
16+
runs-on: ubuntu-24.04
1917
steps:
2018
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
2119
with:
@@ -28,6 +26,6 @@ jobs:
2826
run: npx envinfo
2927
- name: Build lto
3028
run: |
31-
apt-get update && apt-get install ninja-build python-is-python3 -y
29+
sudo apt-get update && sudo apt-get install ninja-build -y
3230
./configure --enable-lto --ninja
3331
ninja -C out/Release

‎.github/workflows/test-internet.yml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
pull_request:
99
types: [opened, synchronize, reopened, ready_for_review]
1010
paths:
11+
- .github/workflows/test-internet.yml
1112
- test/internet/**
1213
- internal/dns/**
1314
- lib/dns.js
@@ -19,6 +20,7 @@ on:
1920
- v[0-9]+.x-staging
2021
- v[0-9]+.x
2122
paths:
23+
- .github/workflows/test-internet.yml
2224
- test/internet/**
2325
- internal/dns/**
2426
- lib/dns.js
@@ -31,14 +33,16 @@ concurrency:
3133
env:
3234
PYTHON_VERSION: '3.12'
3335
FLAKY_TESTS: keep_retrying
36+
CC: clang
37+
CXX: clang++
3438

3539
permissions:
3640
contents: read
3741

3842
jobs:
3943
test-internet:
4044
if: github.repository == 'nodejs/node' || github.event_name != 'schedule'
41-
runs-on: ubuntu-latest
45+
runs-on: ubuntu-24.04
4246
steps:
4347
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
4448
with:

‎.github/workflows/test-linux.yml‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,17 @@ concurrency:
2525
env:
2626
PYTHON_VERSION: '3.12'
2727
FLAKY_TESTS: keep_retrying
28+
CC: sccache clang
29+
CXX: sccache clang++
30+
SCCACHE_GHA_ENABLED: 'true'
2831

2932
permissions:
3033
contents: read
3134

3235
jobs:
3336
test-linux:
3437
if: github.event.pull_request.draft == false
35-
runs-on: ubuntu-latest
36-
env:
37-
CC: sccache gcc
38-
CXX: sccache g++
39-
SCCACHE_GHA_ENABLED: 'true'
38+
runs-on: ubuntu-24.04
4039
steps:
4140
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
4241
with:

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL