Commit d1b6407
build: make node-gyp output silent
As it is, node-gyp produces a lot of build related verbose messages.
Latest node-gyp upgrade allows us to specify --silent flag to suppress
those messages. Except for CI, addons build will run silently.
PR-URL: #8990
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>1 parent 759e8fd commit d1b6407
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,6 +8,7 @@ PREFIX ?= /usr/local | |||
| 8 | 8 | FLAKY_TESTS ?= run | |
| 9 | 9 | TEST_CI_ARGS ?= | |
| 10 | 10 | STAGINGSERVER ?= node-www | |
| 11 | + LOGLEVEL ?= silent | ||
| 11 | 12 | ||
| 12 | 13 | OSTYPE := $(shell uname -s | tr '[A-Z]' '[a-z]') | |
| 13 | 14 | ||
@@ -150,7 +151,8 @@ test/addons/.buildstamp: config.gypi \ | |||
| 150 | 151 | # Cannot use $(wildcard test/addons/*/) here, it's evaluated before | |
| 151 | 152 | # embedded addons have been generated from the documentation. | |
| 152 | 153 | for dirname in test/addons/*/; do \ | |
| 153 | - $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ | ||
| 154 | + echo "\nRunning addons test $$PWD/$$dirname" ; \ | ||
| 155 | + $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp --loglevel=$(LOGLEVEL) rebuild \ | ||
| 154 | 156 | --python="$(PYTHON)" \ | |
| 155 | 157 | --directory="$$PWD/$$dirname" \ | |
| 156 | 158 | --nodedir="$$PWD"; \ | |
@@ -180,6 +182,7 @@ CI_NATIVE_SUITES := addons | |||
| 180 | 182 | CI_JS_SUITES := doctool message parallel pseudo-tty sequential | |
| 181 | 183 | ||
| 182 | 184 | # Build and test addons without building anything else | |
| 185 | + test-ci-native: LOGLEVEL := info | ||
| 183 | 186 | test-ci-native: | test/addons/.buildstamp | |
| 184 | 187 | $(PYTHON) tools/test.py -p tap --logfile test.tap \ | |
| 185 | 188 | --mode=release --flaky-tests=$(FLAKY_TESTS) \ | |
@@ -191,6 +194,7 @@ test-ci-js: | |||
| 191 | 194 | --mode=release --flaky-tests=$(FLAKY_TESTS) \ | |
| 192 | 195 | $(TEST_CI_ARGS) $(CI_JS_SUITES) | |
| 193 | 196 | ||
| 197 | + test-ci: LOGLEVEL := info | ||
| 194 | 198 | test-ci: | build-addons | |
| 195 | 199 | out/Release/cctest --gtest_output=tap:cctest.tap | |
| 196 | 200 | $(PYTHON) tools/test.py -p tap --logfile test.tap --mode=release --flaky-tests=$(FLAKY_TESTS) \ | |
0 commit comments