src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> · nodejs/node@d1c6f86 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d1c6f86

Browse filesBrowse the repository at this point in the historyBrowse files

Aditi-1400

authored and

aduh95

committed

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

According to V8's public API documentation, local handles (i.e., objects of type v8::Local<T>) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of `v8::Local`, specifically the `std::vector<v8::Local<v8::String>>` with recently introduced `v8::LocalVector<T>`. This is first of the series of commits to replace all `std::vector<v8::Local<T>>` to use `v8::LocalVector<T>`. PR-URL: #57578 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent b5cd0eb commit d1c6f86
Copy full SHA for d1c6f86

2 files changed

+6-5Lines changed: 6 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_builtins.cc
  • node_builtins.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_builtins.cc‎

Copy file name to clipboardExpand all lines: src/node_builtins.cc

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -17,6 +17,7 @@ using v8::FunctionCallbackInfo;
17	17	using v8::IntegrityLevel;
18	18	using v8::Isolate;
19	19	using v8::Local;
	20	+ using v8::LocalVector;
20	21	using v8::MaybeLocal;
21	22	using v8::Name;
22	23	using v8::None;
@@ -268,7 +269,7 @@ void BuiltinLoader::AddExternalizedBuiltin(const char* id,
268	269	MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
269	270	Local<Context> context,
270	271	const char* id,
271		- std::vector<Local<String>>* parameters,
	272	+ LocalVector<String>* parameters,
272	273	Realm* optional_realm) {
273	274	Isolate* isolate = context->GetIsolate();
274	275	EscapableHandleScope scope(isolate);
@@ -392,8 +393,8 @@ void BuiltinLoader::SaveCodeCache(const char* id, Local<Function> fun) {
392	393	MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,
393	394	const char* id,
394	395	Realm* optional_realm) {
395		- std::vector<Local<String>> parameters;
396	396	Isolate* isolate = context->GetIsolate();
	397	+ LocalVector<String> parameters(isolate);
397	398	// Detects parameters of the scripts based on module ids.
398	399	// internal/bootstrap/realm: process, getLinkedBinding,
399	400	// getInternalBinding, primordials
@@ -507,7 +508,7 @@ MaybeLocal<Value> BuiltinLoader::CompileAndCall(Local<Context> context,
507	508	MaybeLocal<Function> BuiltinLoader::LookupAndCompile(
508	509	Local<Context> context,
509	510	const char* id,
510		- std::vector<Local<String>>* parameters,
	511	+ LocalVector<String>* parameters,
511	512	Realm* optional_realm) {
512	513	return LookupAndCompileInternal(context, id, parameters, optional_realm);
513	514	}

Collapse file

‎src/node_builtins.h‎

Copy file name to clipboardExpand all lines: src/node_builtins.h

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -100,7 +100,7 @@ class NODE_EXTERN_PRIVATE BuiltinLoader {
100	100	v8::MaybeLocal<v8::Function> LookupAndCompile(
101	101	v8::Local<v8::Context> context,
102	102	const char* id,
103		- std::vector<v8::Local<v8::String>>* parameters,
	103	+ v8::LocalVector<v8::String>* parameters,
104	104	Realm* optional_realm);
105	105
106	106	v8::MaybeLocal<v8::Value> CompileAndCall(v8::Local<v8::Context> context,
@@ -156,7 +156,7 @@ class NODE_EXTERN_PRIVATE BuiltinLoader {
156	156	v8::MaybeLocal<v8::Function> LookupAndCompileInternal(
157	157	v8::Local<v8::Context> context,
158	158	const char* id,
159		- std::vector<v8::Local<v8::String>>* parameters,
	159	+ v8::LocalVector<v8::String>* parameters,
160	160	Realm* optional_realm);
161	161	void SaveCodeCache(const char* id, v8::Local<v8::Function> fn);
162	162

0 commit comments

Comments

0 (0)