src: initialize `Environment` members in class definition · nodejs/node@d1ff107 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d1ff107

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

committed

src: initialize Environment members in class definition

Initialize primitive members of `Environment` in the class definition for clarity. PR-URL: #25369 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

1 parent 071f84e commit d1ff107
Copy full SHA for d1ff107

2 files changed

+6-12Lines changed: 6 additions & 12 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • env.cc
  • env.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/env.cc‎

Copy file name to clipboardExpand all lines: src/env.cc

-6Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -171,15 +171,9 @@ Environment::Environment(IsolateData* isolate_data,
171	171	immediate_info_(context->GetIsolate()),
172	172	tick_info_(context->GetIsolate()),
173	173	timer_base_(uv_now(isolate_data->event_loop())),
174		- printed_error_(false),
175		- abort_on_uncaught_exception_(false),
176		- emit_env_nonstring_warning_(true),
177		- emit_err_name_warning_(true),
178		- makecallback_cntr_(0),
179	174	should_abort_on_uncaught_toggle_(isolate_, 1),
180	175	trace_category_state_(isolate_, kTraceCategoryCount),
181	176	stream_base_state_(isolate_, StreamBase::kNumStreamBaseStateFields),
182		- http_parser_buffer_(nullptr),
183	177	fs_stats_field_array_(isolate_, kFsStatsBufferLength),
184	178	fs_stats_field_bigint_array_(isolate_, kFsStatsBufferLength),
185	179	context_(context->GetIsolate(), context) {

Collapse file

‎src/env.h‎

Copy file name to clipboardExpand all lines: src/env.h

+6-6Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -945,11 +945,11 @@ class Environment {
945	945	ImmediateInfo immediate_info_;
946	946	TickInfo tick_info_;
947	947	const uint64_t timer_base_;
948		- bool printed_error_;
949		- bool abort_on_uncaught_exception_;
950		- bool emit_env_nonstring_warning_;
951		- bool emit_err_name_warning_;
952		- size_t makecallback_cntr_;
	948	+ bool printed_error_ = false;
	949	+ bool abort_on_uncaught_exception_ = false;
	950	+ bool emit_env_nonstring_warning_ = true;
	951	+ bool emit_err_name_warning_ = true;
	952	+ size_t makecallback_cntr_ = 0;
953	953	std::vector<double> destroy_async_id_list_;
954	954
955	955	std::shared_ptr<EnvironmentOptions> options_;
@@ -1004,7 +1004,7 @@ class Environment {
1004	1004	double* heap_statistics_buffer_ = nullptr;
1005	1005	double* heap_space_statistics_buffer_ = nullptr;
1006	1006
1007		- char* http_parser_buffer_;
	1007	+ char* http_parser_buffer_ = nullptr;
1008	1008	bool http_parser_buffer_in_use_ = false;
1009	1009	std::unique_ptr<http2::Http2State> http2_state_;
1010	1010

0 commit comments

Comments

0 (0)