Commit d29b805
doc: update http server response 'close' event
Two places emits `close` events:
`resOnFinish` calls `emitCloseNT`, which happens when the result is
completed:
https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L695
It gets attached once the socket is assigned:
https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L226
And detached if the response is completed:
https://github.com/nodejs/node/blob/master/lib/_http_server.js#L709
https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L232
Which means, it can only be reached in this case, for premature socket
termination.
PR-URL: #34472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent b261895 commit d29b805
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1335,7 +1335,8 @@ passed as the second parameter to the [`'request'`][] event. | |||
| 1335 | 1335 | added: v0.6.7 | |
| 1336 | 1336 | --> | |
| 1337 | 1337 | ||
| 1338 | - Indicates that the underlying connection was terminated. | ||
| 1338 | + Indicates that the the response is completed, or its underlying connection was | ||
| 1339 | + terminated prematurely (before the response completion). | ||
| 1339 | 1340 | ||
| 1340 | 1341 | ### Event: `'finish'` | |
| 1341 | 1342 | <!-- YAML | |
0 commit comments