test: fix calculations in test-worker-resource-limits · nodejs/node@d311916 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d311916

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

targos

committed

test: fix calculations in test-worker-resource-limits

The heap size limit should be the sum of old generation and young generation size limits, and does not solely depend on the limit of the old generation. PR-URL: #42702 Refs: #35711 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 6bd2420 commit d311916
Copy full SHA for d311916

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-worker-resource-limits.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-worker-resource-limits.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-worker-resource-limits.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -35,10 +35,10 @@ if (!process.env.HAS_STARTED_WORKER) {
35	35	assert.deepStrictEqual(resourceLimits, testResourceLimits);
36	36	const array = [];
37	37	while (true) {
38		- // Leave 10% wiggle room here, and 20% on debug builds.
39		- const wiggleRoom = common.buildType === 'Release' ? 1.1 : 1.2;
40	38	const usedMB = v8.getHeapStatistics().used_heap_size / 1024 / 1024;
41		- assert(usedMB < resourceLimits.maxOldGenerationSizeMb * wiggleRoom);
	39	+ const maxReservedSize = resourceLimits.maxOldGenerationSizeMb +
	40	+ resourceLimits.maxYoungGenerationSizeMb;
	41	+ assert(usedMB < maxReservedSize);
42	42
43	43	let seenSpaces = 0;
44	44	for (const { space_name, space_size } of v8.getHeapSpaceStatistics()) {

0 commit comments

Comments

0 (0)