stream: remove redundant method check from iter.pipeToSync · nodejs/node@d34cfb5 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d34cfb5

Browse filesBrowse the repository at this point in the historyBrowse files

Renegade334

authored and

aduh95

committed

stream: remove redundant method check from iter.pipeToSync

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #63099 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 30c4b36 commit d34cfb5
Copy full SHA for d34cfb5

1 file changed

+1-6Lines changed: 1 addition & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/streams/iter
  • pull.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/streams/iter/pull.js‎

Copy file name to clipboardExpand all lines: lib/internal/streams/iter/pull.js

+1-6Lines changed: 1 addition & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -764,7 +764,6 @@ function pipeToSync(source, ...args) {
764	764	normalized;
765	765
766	766	let totalBytes = 0;
767		- const hasWriteSync = typeof writer.writeSync === 'function';
768	767	const hasWritevSync = typeof writer.writevSync === 'function';
769	768	const hasEndSync = typeof writer.endSync === 'function';
770	769
@@ -778,11 +777,7 @@ function pipeToSync(source, ...args) {
778	777	} else {
779	778	for (let i = 0; i < batch.length; i++) {
780	779	const chunk = batch[i];
781		- if (hasWriteSync) {
782		- writer.writeSync(chunk);
783		- } else {
784		- writer.write(chunk);
785		- }
	780	+ writer.writeSync(chunk);
786	781	totalBytes += TypedArrayPrototypeGetByteLength(chunk);
787	782	}
788	783	}

0 commit comments

Comments

0 (0)