test: remove unnecessary common.platformTimeout() call · nodejs/node@d3bac60 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d3bac60

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

MylesBorins

committed

test: remove unnecessary common.platformTimeout() call

Applying platformTimeout() to the interval is counterproductive. It should be applied to the request timeout duration only. PR-URL: #30677 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 564e477 commit d3bac60
Copy full SHA for d3bac60

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/sequential
  • test-http-server-consumed-timeout.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/sequential/test-http-server-consumed-timeout.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-http-server-consumed-timeout.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -41,7 +41,7 @@ function runTest(timeoutDuration) {
41	41	const interval = setInterval(() => {
42	42	intervalWasInvoked = true;
43	43	req.write('a');
44		- }, common.platformTimeout(25));
	44	+ }, 25);
45	45	setTimeout(() => {
46	46	clearInterval(interval);
47	47	req.end();

0 commit comments

Comments

0 (0)