Commit d3bd4b4
tools: fix type mismatch in test runner
`output.diagnostic` is a list that is appended to on SmartOS when
retrying a test due to `ECONNREFUSED`. The test runner checks if
`output.diagnostic` is truthy and, if so, assigns its value to
`self.traceback`. However `self.traceback` is supposed to be a string,
and `_printDiagnostic()` in the `TapProgressIndicator` attempts to call
`splitlines()` on it, which fails if it is a list with:
AttributeError: 'list' object has no attribute 'splitlines'
PR-URL: #38289
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent 05f41cd commit d3bd4b4
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -375,7 +375,10 @@ def HasRun(self, output): | |||
| 375 | 375 | ||
| 376 | 376 | if output.diagnostic: | |
| 377 | 377 | self.severity = 'ok' | |
| 378 | - self.traceback = output.diagnostic | ||
| 378 | + if isinstance(output.diagnostic, list): | ||
| 379 | + self.traceback = '\n'.join(output.diagnostic) | ||
| 380 | + else: | ||
| 381 | + self.traceback = output.diagnostic | ||
| 379 | 382 | ||
| 380 | 383 | ||
| 381 | 384 | duration = output.test.duration | |
0 commit comments