Commit d429aa2
src: remove deprecated node::CreatePlatform and node::FreePlatform
PR-URL: #58470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent e0ae14c commit d429aa2
2 files changed
Lines changed: 6 additions & 33 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -583,26 +583,6 @@ MultiIsolatePlatform* GetMultiIsolatePlatform(IsolateData* env) { | |||
| 583 | 583 | return env->platform(); | |
| 584 | 584 | } | |
| 585 | 585 | ||
| 586 | - MultiIsolatePlatform* CreatePlatform( | ||
| 587 | - int thread_pool_size, | ||
| 588 | - node::tracing::TracingController* tracing_controller) { | ||
| 589 | - return CreatePlatform( | ||
| 590 | - thread_pool_size, | ||
| 591 | - static_cast<v8::TracingController*>(tracing_controller)); | ||
| 592 | - } | ||
| 593 | - | ||
| 594 | - MultiIsolatePlatform* CreatePlatform( | ||
| 595 | - int thread_pool_size, | ||
| 596 | - v8::TracingController* tracing_controller) { | ||
| 597 | - return MultiIsolatePlatform::Create(thread_pool_size, | ||
| 598 | - tracing_controller) | ||
| 599 | - .release(); | ||
| 600 | - } | ||
| 601 | - | ||
| 602 | - void FreePlatform(MultiIsolatePlatform* platform) { | ||
| 603 | - delete platform; | ||
| 604 | - } | ||
| 605 | - | ||
| 606 | 586 | std::unique_ptr<MultiIsolatePlatform> MultiIsolatePlatform::Create( | |
| 607 | 587 | int thread_pool_size, | |
| 608 | 588 | v8::TracingController* tracing_controller, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -832,19 +832,12 @@ NODE_EXTERN void GetNodeReport(Environment* env, | |||
| 832 | 832 | NODE_EXTERN MultiIsolatePlatform* GetMultiIsolatePlatform(Environment* env); | |
| 833 | 833 | NODE_EXTERN MultiIsolatePlatform* GetMultiIsolatePlatform(IsolateData* env); | |
| 834 | 834 | ||
| 835 | - NODE_DEPRECATED("Use MultiIsolatePlatform::Create() instead", | ||
| 836 | - NODE_EXTERN MultiIsolatePlatform* CreatePlatform( | ||
| 837 | - int thread_pool_size, | ||
| 838 | - v8::TracingController* tracing_controller)); | ||
| 839 | - NODE_DEPRECATED("Use MultiIsolatePlatform::Create() instead", | ||
| 840 | - NODE_EXTERN void FreePlatform(MultiIsolatePlatform* platform)); | ||
| 841 | - | ||
| 842 | - // Get/set the currently active tracing controller. Using CreatePlatform() | ||
| 843 | - // will implicitly set this by default. This is global and should be initialized | ||
| 844 | - // along with the v8::Platform instance that is being used. `controller` | ||
| 845 | - // is allowed to be `nullptr`. | ||
| 846 | - // This is used for tracing events from Node.js itself. V8 uses the tracing | ||
| 847 | - // controller returned from the active `v8::Platform` instance. | ||
| 835 | + // Get/set the currently active tracing controller. Using | ||
| 836 | + // MultiIsolatePlatform::Create() will implicitly set this by default. This is | ||
| 837 | + // global and should be initialized along with the v8::Platform instance that is | ||
| 838 | + // being used. `controller` is allowed to be `nullptr`. This is used for tracing | ||
| 839 | + // events from Node.js itself. V8 uses the tracing controller returned from the | ||
| 840 | + // active `v8::Platform` instance. | ||
| 848 | 841 | NODE_EXTERN v8::TracingController* GetTracingController(); | |
| 849 | 842 | NODE_EXTERN void SetTracingController(v8::TracingController* controller); | |
| 850 | 843 | ||
0 commit comments