Commit d46446a
v8: replace Buffer with FastBuffer in deserialize
Replace the Buffer constructor with a FastBuffer in v8.deserialize in
order to avoid calling the Buffer constructor and thus triggering a
deprecation warning from code inside the core.
Fixes: #21181
PR-URL: #21196
Fixes: #21181
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 13fd09b commit d46446a
2 files changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -143,7 +143,7 @@ const arrayBufferViewTypeToIndex = new Map(); | |||
| 143 | 143 | } | |
| 144 | 144 | } | |
| 145 | 145 | ||
| 146 | - const bufferConstructorIndex = arrayBufferViewTypes.push(Buffer) - 1; | ||
| 146 | + const bufferConstructorIndex = arrayBufferViewTypes.push(FastBuffer) - 1; | ||
| 147 | 147 | ||
| 148 | 148 | class DefaultSerializer extends Serializer { | |
| 149 | 149 | constructor() { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,8 @@ | |||
| 1 | + // Flags: --pending-deprecation --no-warnings | ||
| 2 | + 'use strict'; | ||
| 3 | + | ||
| 4 | + const common = require('../common'); | ||
| 5 | + const v8 = require('v8'); | ||
| 6 | + | ||
| 7 | + process.on('warning', common.mustNotCall()); | ||
| 8 | + v8.deserialize(v8.serialize(Buffer.alloc(0))); | ||
0 commit comments