url: fix URLSearchParams(null) to prudce null= per spec · nodejs/node@d5be94e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d5be94e

Browse filesBrowse the repository at this point in the historyBrowse files

marcopiraccini

authored and

aduh95

committed

url: fix URLSearchParams(null) to prudce null= per spec

Signed-off-by: marcopiraccini <marco.piraccini@gmail.com> PR-URL: #63782 Fixes: #63559 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 915e3e2 commit d5be94e
Copy full SHA for d5be94e

2 files changed

+9-3Lines changed: 9 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • url.js
• test/parallel
  • test-whatwg-url-custom-searchparams-constructor.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/url.js‎

Copy file name to clipboardExpand all lines: lib/internal/url.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -337,9 +337,9 @@ class URLSearchParams {
337	337	constructor(init = undefined) {
338	338	markTransferMode(this, false, false);
339	339
340		- if (init == null) {
	340	+ if (init === undefined) {
341	341	// Do nothing
342		- } else if (typeof init === 'object' || typeof init === 'function') {
	342	+ } else if (init !== null && (typeof init === 'object' || typeof init === 'function')) {
343	343	const method = init[SymbolIterator];
344	344	if (method === this[SymbolIterator] && #searchParams in init) {
345	345	// While the spec does not have this branch, we can use it as a

Collapse file

‎test/parallel/test-whatwg-url-custom-searchparams-constructor.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-whatwg-url-custom-searchparams-constructor.js

+7-1Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -28,8 +28,14 @@ function makeIterableFunc(array) {
28	28	let params;
29	29	params = new URLSearchParams(undefined);
30	30	assert.strictEqual(params.toString(), '');
	31	+ // Per WebIDL union resolution, null is coerced to the USVString "null".
	32	+ // Refs: https://url.spec.whatwg.org/#interface-urlsearchparams
31	33	params = new URLSearchParams(null);
32		- assert.strictEqual(params.toString(), '');
	34	+ assert.strictEqual(params.toString(), 'null=');
	35	+ params = new URLSearchParams(false);
	36	+ assert.strictEqual(params.toString(), 'false=');
	37	+ params = new URLSearchParams(0);
	38	+ assert.strictEqual(params.toString(), '0=');
33	39	params = new URLSearchParams(
34	40	makeIterableFunc([['key', 'val'], ['key2', 'val2']])
35	41	);

0 commit comments

Comments

0 (0)