test: add test for reused AbortController with execfile() · nodejs/node@d5d56ec · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d5d56ec

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

danielleadams

committed

test: add test for reused AbortController with execfile()

Test that reusing an aborted AbortController with execfile() results in immediate SIGTERM. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

1 parent 190ddce commit d5d56ec
Copy full SHA for d5d56ec

1 file changed

+15-2Lines changed: 15 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-child-process-execfile.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-child-process-execfile.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-execfile.js

+15-2Lines changed: 15 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -53,11 +53,24 @@ const execOpts = { encoding: 'utf8', shell: true };
53	53	const ac = new AbortController();
54	54	const { signal } = ac;
55	55
56		- const callback = common.mustCall((err) => {
	56	+ const firstCheck = common.mustCall((err) => {
57	57	assert.strictEqual(err.code, 'ABORT_ERR');
58	58	assert.strictEqual(err.name, 'AbortError');
	59	+ assert.strictEqual(err.signal, undefined);
	60	+ });
	61	+
	62	+ const secondCheck = common.mustCall((err) => {
	63	+ assert.strictEqual(err.code, null);
	64	+ assert.strictEqual(err.name, 'Error');
	65	+ assert.strictEqual(err.signal, 'SIGTERM');
59	66	});
60		- execFile(process.execPath, [echoFixture, 0], { signal }, callback);
	67	+
	68	+ execFile(process.execPath, [echoFixture, 0], { signal }, (err) => {
	69	+ firstCheck(err);
	70	+ // Test that re-using the aborted signal results in immediate SIGTERM.
	71	+ execFile(process.execPath, [echoFixture, 0], { signal }, secondCheck);
	72	+ });
	73	+
61	74	ac.abort();
62	75	}
63	76

0 commit comments

Comments

0 (0)