Commit d5e1b82
fs: accept non-32-bit length in writeBuffer
Since `length` is `size_t`, it can accept 64-bit integers too.
Refs: https://man7.org/linux/man-pages/man2/write.2.html
Fixes: #36643
PR-URL: #36667
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Reviewed-By: Zeyu Yang <himself65@outlook.com>1 parent 5cb8b16 commit d5e1b82
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1832,8 +1832,8 @@ static void WriteBuffer(const FunctionCallbackInfo<Value>& args) { | |||
| 1832 | 1832 | CHECK_LE(static_cast<uint64_t>(off_64), buffer_length); | |
| 1833 | 1833 | const size_t off = static_cast<size_t>(off_64); | |
| 1834 | 1834 | ||
| 1835 | - CHECK(args[3]->IsInt32()); | ||
| 1836 | - const size_t len = static_cast<size_t>(args[3].As<Int32>()->Value()); | ||
| 1835 | + CHECK(IsSafeJsInt(args[3])); | ||
| 1836 | + const size_t len = static_cast<size_t>(args[3].As<Integer>()->Value()); | ||
| 1837 | 1837 | CHECK(Buffer::IsWithinBounds(off, len, buffer_length)); | |
| 1838 | 1838 | CHECK_LE(len, buffer_length); | |
| 1839 | 1839 | CHECK_GE(off + len, off); | |
0 commit comments