Commit d6346e1
test: deflake test-fs-read-optional-params
If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.
Run the test for no options object first.
PR-URL: #37991
Fixes: #37946
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent 8598745 commit d6346e1
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,14 +11,14 @@ const expected = Buffer.from('xyz\n'); | |||
| 11 | 11 | const defaultBufferAsync = Buffer.alloc(16384); | |
| 12 | 12 | const bufferAsOption = Buffer.allocUnsafe(expected.length); | |
| 13 | 13 | ||
| 14 | - // Test passing in an empty options object | ||
| 15 | - fs.read(fd, { position: 0 }, common.mustCall((err, bytesRead, buffer) => { | ||
| 14 | + // Test not passing in any options object | ||
| 15 | + fs.read(fd, common.mustCall((err, bytesRead, buffer) => { | ||
| 16 | 16 | assert.strictEqual(bytesRead, expected.length); | |
| 17 | 17 | assert.deepStrictEqual(defaultBufferAsync.length, buffer.length); | |
| 18 | 18 | })); | |
| 19 | 19 | ||
| 20 | - // Test not passing in any options object | ||
| 21 | - fs.read(fd, common.mustCall((err, bytesRead, buffer) => { | ||
| 20 | + // Test passing in an empty options object | ||
| 21 | + fs.read(fd, { position: 0 }, common.mustCall((err, bytesRead, buffer) => { | ||
| 22 | 22 | assert.strictEqual(bytesRead, expected.length); | |
| 23 | 23 | assert.deepStrictEqual(defaultBufferAsync.length, buffer.length); | |
| 24 | 24 | })); | |
0 commit comments