Commit d6aca0c
test: increase spin for eventloop test on s390
It was excluded as it was failing intermittently. Likely
that s390 was just so fast times were rounded down to 0.
Increase the spin time on s390x only.
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #56228
Refs: #41286
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent 82461af commit d6aca0c
2 files changed
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -51,7 +51,3 @@ test-tls-securepair-client: PASS, FLAKY | |||
| 51 | 51 | [$arch==arm] | |
| 52 | 52 | # https://github.com/nodejs/node/issues/49933 | |
| 53 | 53 | test-watch-mode-inspect: SKIP | |
| 54 | - | ||
| 55 | - [$arch==s390x] | ||
| 56 | - # https://github.com/nodejs/node/issues/41286 | ||
| 57 | - test-performance-eventloopdelay: PASS, FLAKY | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,6 +3,7 @@ | |||
| 3 | 3 | ||
| 4 | 4 | const common = require('../common'); | |
| 5 | 5 | const assert = require('assert'); | |
| 6 | + const os = require('os'); | ||
| 6 | 7 | const { | |
| 7 | 8 | monitorEventLoopDelay | |
| 8 | 9 | } = require('perf_hooks'); | |
@@ -51,9 +52,13 @@ const { sleep } = require('internal/util'); | |||
| 51 | 52 | } | |
| 52 | 53 | ||
| 53 | 54 | { | |
| 55 | + const s390x = os.arch() === 's390x'; | ||
| 54 | 56 | const histogram = monitorEventLoopDelay({ resolution: 1 }); | |
| 55 | 57 | histogram.enable(); | |
| 56 | 58 | let m = 5; | |
| 59 | + if (s390x) { | ||
| 60 | + m = m * 2; | ||
| 61 | + } | ||
| 57 | 62 | function spinAWhile() { | |
| 58 | 63 | sleep(1000); | |
| 59 | 64 | if (--m > 0) { | |
0 commit comments