lib: create global console properties at snapshot build time · nodejs/node@d6e8d03 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d6e8d03

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

richardlau

committed

lib: create global console properties at snapshot build time

It is safe to create the console properties for the global console at snapshot build time. Streams must still be created lazily however because they need special synchronization for the handles. PR-URL: #51700 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

1 parent fdc7d75 commit d6e8d03
Copy full SHA for d6e8d03

2 files changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/console
  • constructor.js
  • global.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/console/constructor.js‎

Copy file name to clipboardExpand all lines: lib/internal/console/constructor.js

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -689,8 +689,6 @@ Console.prototype.groupCollapsed = Console.prototype.group;
689	689
690	690	function initializeGlobalConsole(globalConsole) {
691	691	globalConsole[kBindStreamsLazy](process);
692		- globalConsole[kBindProperties](true, 'auto');
693		-
694	692	const {
695	693	namespace: {
696	694	addSerializeCallback,

Collapse file

‎lib/internal/console/global.js‎

Copy file name to clipboardExpand all lines: lib/internal/console/global.js

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -21,6 +21,7 @@ const {
21	21
22	22	const {
23	23	Console,
	24	+ kBindProperties,
24	25	} = require('internal/console/constructor');
25	26
26	27	const globalConsole = { __proto__: {} };
@@ -41,6 +42,8 @@ for (const prop of ReflectOwnKeys(Console.prototype)) {
41	42	ReflectDefineProperty(globalConsole, prop, desc);
42	43	}
43	44
	45	+ globalConsole[kBindProperties](true, 'auto');
	46	+
44	47	// This is a legacy feature - the Console constructor is exposed on
45	48	// the global console instance.
46	49	globalConsole.Console = Console;

0 commit comments

Comments

0 (0)