Commit d713e5a
doc: update GOVERNANCE.md
This consists of some hopefully-uncontroversial
simplifications/clarifications to the text. The one substantial change
is to update Node.js Board of Directors to be the OpenJS Board of
Directors.
PR-URL: #30259
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent 3d39be7 commit d713e5a
1 file changed
Lines changed: 16 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -15,22 +15,21 @@ | |||
| 15 | 15 | ## Collaborators | |
| 16 | 16 | ||
| 17 | 17 | Node.js Core Collaborators maintain the [nodejs/node][] GitHub repository. | |
| 18 | - The GitHub team for Node.js Core Collaborators is @nodejs/collaborators. Their | ||
| 19 | - privileges include but are not limited to: | ||
| 18 | + The GitHub team for Node.js Core Collaborators is @nodejs/collaborators. | ||
| 19 | + Collaborators have: | ||
| 20 | 20 | ||
| 21 | 21 | * Commit access to the [nodejs/node][] repository | |
| 22 | 22 | * Access to the Node.js continuous integration (CI) jobs | |
| 23 | 23 | ||
| 24 | 24 | Both Collaborators and non-Collaborators may propose changes to the Node.js | |
| 25 | 25 | source code. The mechanism to propose such a change is a GitHub pull request. | |
| 26 | - Collaborators are responsible for reviewing and merging (_landing_) | ||
| 27 | - pull requests. | ||
| 26 | + Collaborators review and merge (_land_) pull requests. | ||
| 28 | 27 | ||
| 29 | - At least two Collaborators must approve a pull request before the pull request | ||
| 30 | - can land. (One Collaborator approval is enough if the pull request has been open | ||
| 31 | - for more than 7 days.) Approving a pull request indicates that the Collaborator | ||
| 32 | - accepts responsibility for the change. Approval must be from Collaborators who | ||
| 33 | - are not authors of the change. | ||
| 28 | + Two Collaborators must approve a pull request before the pull request can land. | ||
| 29 | + (One Collaborator approval is enough if the pull request has been open for more | ||
| 30 | + than 7 days.) Approving a pull request indicates that the Collaborator accepts | ||
| 31 | + responsibility for the change. Approval must be from Collaborators who are not | ||
| 32 | + authors of the change. | ||
| 34 | 33 | ||
| 35 | 34 | If a Collaborator opposes a proposed change, then the change cannot land. The | |
| 36 | 35 | exception is if the TSC votes to approve the change despite the opposition. | |
@@ -39,13 +38,11 @@ result in Collaborators removing their opposition. | |||
| 39 | 38 | ||
| 40 | 39 | See: | |
| 41 | 40 | ||
| 42 | - * [Current list of Collaborators](./README.md#current-project-team-members) | ||
| 41 | + * [List of Collaborators](./README.md#current-project-team-members) | ||
| 43 | 42 | * [A guide for Collaborators](./COLLABORATOR_GUIDE.md) | |
| 44 | 43 | ||
| 45 | 44 | ### Collaborator Activities | |
| 46 | 45 | ||
| 47 | - Typical activities of a Collaborator include: | ||
| 48 | - | ||
| 49 | 46 | * Helping users and novice contributors | |
| 50 | 47 | * Contributing code and documentation changes that improve the project | |
| 51 | 48 | * Reviewing and commenting on issues and pull requests | |
@@ -71,7 +68,7 @@ The current list of TSC members is in | |||
| 71 | 68 | [the project README](./README.md#current-project-team-members). | |
| 72 | 69 | ||
| 73 | 70 | The [TSC Charter][] governs the operations of the TSC. All changes to the | |
| 74 | - Charter need approval by the Node.js Board of Directors. | ||
| 71 | + Charter need approval by the OpenJS Foundation Board of Directors. | ||
| 75 | 72 | ||
| 76 | 73 | ### TSC Meetings | |
| 77 | 74 | ||
@@ -124,7 +121,7 @@ Provide a summary of the nominee's contributions. For example: | |||
| 124 | 121 | * Use the link `https://github.com/nodejs/node/issues?q=commenter:GITHUB_ID` | |
| 125 | 122 | * Reviews on pull requests in the [nodejs/node][] repository | |
| 126 | 123 | * Use the link `https://github.com/nodejs/node/pulls?q=reviewed-by:GITHUB_ID` | |
| 127 | - * Help provided to end users and novice contributors | ||
| 124 | + * Help provided to end-users and novice contributors | ||
| 128 | 125 | * Pull requests and issues opened throughout the Node.js organization | |
| 129 | 126 | * Use the link `https://github.com/search?q=author:GITHUB_ID+org:nodejs` | |
| 130 | 127 | * Comments on pull requests and issues throughout the Node.js organization | |
@@ -144,16 +141,15 @@ frictionless as possible. Use the [Collaborators discussion page][] to request | |||
| 144 | 141 | feedback from other Collaborators in private. A nominator may also work with the | |
| 145 | 142 | nominee to improve their contribution profile. | |
| 146 | 143 | ||
| 147 | - It is possible that Collaborators will overlook someone with valuable | ||
| 148 | - contributions. In that case, the contributor may open an issue or contact a | ||
| 149 | - Collaborator to request a nomination. | ||
| 144 | + Collaborators might overlook someone with valuable contributions. In that case, | ||
| 145 | + the contributor may open an issue or contact a Collaborator to request a | ||
| 146 | + nomination. | ||
| 150 | 147 | ||
| 151 | 148 | ### Onboarding | |
| 152 | 149 | ||
| 153 | 150 | After the nomination passes, a TSC member onboards the new Collaborator. See | |
| 154 | - [the onboarding guide](./doc/onboarding.md) on details of the onboarding | ||
| 155 | - process. In general, the onboarding should occur within a month after the | ||
| 156 | - nomination passes. | ||
| 151 | + [the onboarding guide](./doc/onboarding.md) for details of the onboarding | ||
| 152 | + process. | ||
| 157 | 153 | ||
| 158 | 154 | ## Consensus Seeking Process | |
| 159 | 155 | ||
0 commit comments