Commit d76e7e4
src: improve error handling in CloneSSLCerts
If sk_X509_new() returns NULL or if sk_X509_push() fails, return instead
of silently ignoring the error.
PR-URL: #44410
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>1 parent cae9c5d commit d76e7e4
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -339,8 +339,9 @@ MaybeLocal<Value> GetCipherVersion(Environment* env, const SSL_CIPHER* cipher) { | |||
| 339 | 339 | StackOfX509 CloneSSLCerts(X509Pointer&& cert, | |
| 340 | 340 | const STACK_OF(X509)* const ssl_certs) { | |
| 341 | 341 | StackOfX509 peer_certs(sk_X509_new(nullptr)); | |
| 342 | - if (cert) | ||
| 343 | - sk_X509_push(peer_certs.get(), cert.release()); | ||
| 342 | + if (!peer_certs) return StackOfX509(); | ||
| 343 | + if (cert && !sk_X509_push(peer_certs.get(), cert.release())) | ||
| 344 | + return StackOfX509(); | ||
| 344 | 345 | for (int i = 0; i < sk_X509_num(ssl_certs); i++) { | |
| 345 | 346 | X509Pointer cert(X509_dup(sk_X509_value(ssl_certs, i))); | |
| 346 | 347 | if (!cert || !sk_X509_push(peer_certs.get(), cert.get())) | |
0 commit comments