Commit d77eaee
build: add target specific build_type variable
This commit add a target specific variable named 'build_type' to the
node and node_g targets.
The motivation for doing this is that both targets share the same
prerequisites, and the recepies are the same (apart from the build type)
so some duplication can be avoided.
PR-URL: #33925
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 732b80b commit d77eaee
1 file changed
Lines changed: 6 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -98,13 +98,12 @@ help: ## Print help for targets with comments. | |||
| 98 | 98 | # and recreated which can break the addons build when running test-ci | |
| 99 | 99 | # See comments on the build-addons target for some more info | |
| 100 | 100 | ifeq ($(BUILD_WITH), make) | |
| 101 | - $(NODE_EXE): config.gypi out/Makefile | ||
| 102 | - $(MAKE) -C out BUILDTYPE=Release V=$(V) | ||
| 103 | - if [ ! -r $@ -o ! -L $@ ]; then ln -fs out/Release/$(NODE_EXE) $@; fi | ||
| 104 | - | ||
| 105 | - $(NODE_G_EXE): config.gypi out/Makefile | ||
| 106 | - $(MAKE) -C out BUILDTYPE=Debug V=$(V) | ||
| 107 | - if [ ! -r $@ -o ! -L $@ ]; then ln -fs out/Debug/$(NODE_EXE) $@; fi | ||
| 101 | + $(NODE_EXE): build_type:=Release | ||
| 102 | + $(NODE_G_EXE): build_type:=Debug | ||
| 103 | + $(NODE_EXE) $(NODE_G_EXE): config.gypi out/Makefile | ||
| 104 | + $(MAKE) -C out BUILDTYPE=${build_type} V=$(V) | ||
| 105 | + if [ ! -r $@ -o ! -L $@ ]; then \ | ||
| 106 | + ln -fs out/${build_type}/$(NODE_EXE) $@; fi | ||
| 108 | 107 | else | |
| 109 | 108 | ifeq ($(BUILD_WITH), ninja) | |
| 110 | 109 | ifeq ($(V),1) | |
0 commit comments