Commit d83d89a
crypto: add missing return value check
Add return value check for call to SSL_CTX_add_client_CA
to be consistent with other places it is called
Fixed unused warning in one of the static analysis tools we use
at Red Hat even though it is not being reported by coverity in
the configuration we run.
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #56615
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent bcc1c65 commit d83d89a
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1164,7 +1164,7 @@ void SecureContext::LoadPKCS12(const FunctionCallbackInfo<Value>& args) { | |||
| 1164 | 1164 | X509* ca = sk_X509_value(extra_certs.get(), i); | |
| 1165 | 1165 | ||
| 1166 | 1166 | X509_STORE_add_cert(sc->GetCertStoreOwnedByThisSecureContext(), ca); | |
| 1167 | - SSL_CTX_add_client_CA(sc->ctx_.get(), ca); | ||
| 1167 | + CHECK_EQ(1, SSL_CTX_add_client_CA(sc->ctx_.get(), ca)); | ||
| 1168 | 1168 | } | |
| 1169 | 1169 | ret = true; | |
| 1170 | 1170 | ||
0 commit comments