Commit d86aca9
http: optimize debug function correctly
Exporting a variable that will be mutated later doesn't work.
Refs: #37937
PR-URL: #37966
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent a57dc06 commit d86aca9
4 files changed
Lines changed: 13 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -47,7 +47,6 @@ const assert = require('internal/assert'); | |||
| 47 | 47 | const { once } = require('internal/util'); | |
| 48 | 48 | const { | |
| 49 | 49 | _checkIsHttpToken: checkIsHttpToken, | |
| 50 | - debug, | ||
| 51 | 50 | freeParser, | |
| 52 | 51 | parsers, | |
| 53 | 52 | HTTPParser, | |
@@ -79,6 +78,10 @@ const { | |||
| 79 | 78 | ||
| 80 | 79 | const { addAbortSignal, finished } = require('stream'); | |
| 81 | 80 | ||
| 81 | + let debug = require('internal/util/debuglog').debuglog('http', (fn) => { | ||
| 82 | + debug = fn; | ||
| 83 | + }); | ||
| 84 | + | ||
| 82 | 85 | const INVALID_PATH_REGEX = /[^\u0021-\u00ff]/; | |
| 83 | 86 | const kError = Symbol('kError'); | |
| 84 | 87 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -269,7 +269,6 @@ module.exports = { | |||
| 269 | 269 | chunkExpression: /(?:^|\W)chunked(?:$|\W)/i, | |
| 270 | 270 | continueExpression: /(?:^|\W)100-continue(?:$|\W)/i, | |
| 271 | 271 | CRLF: '\r\n', | |
| 272 | - debug, | ||
| 273 | 272 | freeParser, | |
| 274 | 273 | methods, | |
| 275 | 274 | parsers, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -79,8 +79,12 @@ const { | |||
| 79 | 79 | const { validateString } = require('internal/validators'); | |
| 80 | 80 | const { isUint8Array } = require('internal/util/types'); | |
| 81 | 81 | ||
| 82 | + let debug = require('internal/util/debuglog').debuglog('http', (fn) => { | ||
| 83 | + debug = fn; | ||
| 84 | + }); | ||
| 85 | + | ||
| 82 | 86 | const HIGH_WATER_MARK = getDefaultHighWaterMark(); | |
| 83 | - const { CRLF, debug } = common; | ||
| 87 | + const { CRLF } = common; | ||
| 84 | 88 | ||
| 85 | 89 | const kCorked = Symbol('corked'); | |
| 86 | 90 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -45,7 +45,6 @@ const assert = require('internal/assert'); | |||
| 45 | 45 | const { | |
| 46 | 46 | parsers, | |
| 47 | 47 | freeParser, | |
| 48 | - debug, | ||
| 49 | 48 | CRLF, | |
| 50 | 49 | continueExpression, | |
| 51 | 50 | chunkExpression, | |
@@ -93,6 +92,10 @@ const { observerCounts, constants } = internalBinding('performance'); | |||
| 93 | 92 | const { setTimeout, clearTimeout } = require('timers'); | |
| 94 | 93 | const { NODE_PERFORMANCE_ENTRY_TYPE_HTTP } = constants; | |
| 95 | 94 | ||
| 95 | + let debug = require('internal/util/debuglog').debuglog('http', (fn) => { | ||
| 96 | + debug = fn; | ||
| 97 | + }); | ||
| 98 | + | ||
| 96 | 99 | const dc = require('diagnostics_channel'); | |
| 97 | 100 | const onRequestStartChannel = dc.channel('http.server.request.start'); | |
| 98 | 101 | const onResponseFinishChannel = dc.channel('http.server.response.finish'); | |
0 commit comments