http2: remove no longer userful options.selectPadding · nodejs/node@d86ff60 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d86ff60

Browse filesBrowse the repository at this point in the historyBrowse files

hkleungai

authored and

targos

committed

http2: remove no longer userful options.selectPadding

This is a followup cleanup on a previous PR. Current source code and doc explicitly states that `selectPadding` has been removed for all exports. Refs: #29144 Refs: https://nodejs.org/api/http2.html PR-URL: #58373 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 4606a67 commit d86ff60
Copy full SHA for d86ff60

1 file changed

-3Lines changed: 0 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/http2
  • core.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/http2/core.js‎

Copy file name to clipboardExpand all lines: lib/internal/http2/core.js

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -247,7 +247,6 @@ const kPendingRequestCalls = Symbol('kPendingRequestCalls');
247	247	const kProceed = Symbol('proceed');
248	248	const kRemoteSettings = Symbol('remote-settings');
249	249	const kRequestAsyncResource = Symbol('requestAsyncResource');
250		- const kSelectPadding = Symbol('select-padding');
251	250	const kSentHeaders = Symbol('sent-headers');
252	251	const kSentTrailers = Symbol('sent-trailers');
253	252	const kServer = Symbol('server');
@@ -1100,8 +1099,6 @@ function setupHandle(socket, type, options) {
1100	1099	const handle = new binding.Http2Session(type);
1101	1100	handle[kOwner] = this;
1102	1101
1103		- if (typeof options.selectPadding === 'function')
1104		- this[kSelectPadding] = options.selectPadding;
1105	1102	handle.consume(socket._handle);
1106	1103	handle.ongracefulclosecomplete = this[kMaybeDestroy].bind(this, null);
1107	1104

0 commit comments

Comments

0 (0)