Commit d89f310
committed
module: enable dynamic import flag for esmodules
currently if you want to use dynamic import you must use both the
`--experimental-modules` and the `--harmony-dynamic-imports` flags.
Chrome is currently shipping dynamic import unflagged, the flag
only remains in V8 to guard embedders who have not set the appropriate
callback from throwing an unhandled rejection when the feature is used.
As such it is reasonable to enable the flag by default for
`--experimental-modules`
Backport-PR-URL: #17823
PR-URL: #18387
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>1 parent 00d5422 commit d89f310
3 files changed
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -33,8 +33,8 @@ node --experimental-modules my-app.mjs | |||
| 33 | 33 | ### Supported | |
| 34 | 34 | ||
| 35 | 35 | Only the CLI argument for the main entry point to the program can be an entry | |
| 36 | - point into an ESM graph. In the future `import()` can be used to create entry | ||
| 37 | - points into ESM graphs at run time. | ||
| 36 | + point into an ESM graph. Dynamic import can also be used to create entry points | ||
| 37 | + into ESM graphs at runtime. | ||
| 38 | 38 | ||
| 39 | 39 | ### Unsupported | |
| 40 | 40 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4077,6 +4077,8 @@ static void ParseArgs(int* argc, | |||
| 4077 | 4077 | config_preserve_symlinks = true; | |
| 4078 | 4078 | } else if (strcmp(arg, "--experimental-modules") == 0) { | |
| 4079 | 4079 | config_experimental_modules = true; | |
| 4080 | + new_v8_argv[new_v8_argc] = "--harmony-dynamic-import"; | ||
| 4081 | + new_v8_argc += 1; | ||
| 4080 | 4082 | } else if (strcmp(arg, "--loader") == 0) { | |
| 4081 | 4083 | const char* module = argv[index + 1]; | |
| 4082 | 4084 | if (!config_experimental_modules) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,4 +1,4 @@ | |||
| 1 | - // Flags: --experimental-modules --harmony-dynamic-import | ||
| 1 | + // Flags: --experimental-modules | ||
| 2 | 2 | 'use strict'; | |
| 3 | 3 | const common = require('../common'); | |
| 4 | 4 | const assert = require('assert'); | |
0 commit comments