Revert "src: keep main-thread Isolate attached to platform during Dis… · nodejs/node@d8c927b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 588
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d8c927b

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

MylesBorins

committed

Revert "src: keep main-thread Isolate attached to platform during Dispose"

This reverts commit e460f8c. It is no longer necessary after the previous commit, and restores consistency of the call order between the main thread code, the other call sites, and the documentation. Refs: #31795 PR-URL: #31853 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

1 parent 625d8f7 commit d8c927b
Copy full SHA for d8c927b

1 file changed

+1-5Lines changed: 1 addition & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_main_instance.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_main_instance.cc‎

Copy file name to clipboardExpand all lines: src/node_main_instance.cc

+1-5Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -102,12 +102,8 @@ NodeMainInstance::~NodeMainInstance() {
102	102	if (!owns_isolate_) {
103	103	return;
104	104	}
105		- // TODO(addaleax): Reverse the order of these calls. The fact that we first
106		- // dispose the Isolate is a temporary workaround for
107		- // https://github.com/nodejs/node/issues/31752 -- V8 should not be posting
108		- // platform tasks during Dispose(), but it does in some WASM edge cases.
109		- isolate_->Dispose();
110	105	platform_->UnregisterIsolate(isolate_);
	106	+ isolate_->Dispose();
111	107	}
112	108
113	109	int NodeMainInstance::Run() {

0 commit comments

Comments

0 (0)