Commit d8f1dea
lib: enforce use of URLParse
There's no reason to use the user-mutable `URL.parse` in core.
PR-URL: #61016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 4a22647 commit d8f1dea
3 files changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -30,6 +30,10 @@ const noRestrictedSyntax = [ | |||
| 30 | 30 | selector: "CallExpression[callee.object.name='Error'][callee.property.name='captureStackTrace']", | |
| 31 | 31 | message: "Use 'hideStackFrames' from 'internal/errors' instead.", | |
| 32 | 32 | }, | |
| 33 | + { | ||
| 34 | + selector: "CallExpression[callee.object.name='URL'][callee.property.name='parse']", | ||
| 35 | + message: "Use 'URLParse' from 'internal/url' instead.", | ||
| 36 | + }, | ||
| 33 | 37 | { | |
| 34 | 38 | selector: "AssignmentExpression:matches([left.object.name='Error']):matches([left.name='prepareStackTrace'], [left.property.name='prepareStackTrace'])", | |
| 35 | 39 | message: "Use 'overrideStackTrace' from 'internal/errors' instead.", | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,7 @@ const { | |||
| 37 | 37 | kDeserialize, | |
| 38 | 38 | } = require('internal/worker/js_transferable'); | |
| 39 | 39 | ||
| 40 | - const { URL } = require('internal/url'); | ||
| 40 | + const { URLParse } = require('internal/url'); | ||
| 41 | 41 | ||
| 42 | 42 | const kHandle = Symbol('kHandle'); | |
| 43 | 43 | const kDetail = Symbol('kDetail'); | |
@@ -156,7 +156,7 @@ class SocketAddress { | |||
| 156 | 156 | const { | |
| 157 | 157 | hostname: address, | |
| 158 | 158 | port, | |
| 159 | - } = URL.parse(`http://${input}`); | ||
| 159 | + } = URLParse(`http://${input}`); | ||
| 160 | 160 | if (address.startsWith('[') && address.endsWith(']')) { | |
| 161 | 161 | return new SocketAddress({ | |
| 162 | 162 | address: address.slice(1, -1), | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -30,7 +30,7 @@ const { | |||
| 30 | 30 | fileURLToPath, | |
| 31 | 31 | isURL, | |
| 32 | 32 | pathToFileURL, | |
| 33 | - URL, | ||
| 33 | + URLParse, | ||
| 34 | 34 | } = require('internal/url'); | |
| 35 | 35 | const { | |
| 36 | 36 | emitExperimentalWarning, | |
@@ -652,7 +652,7 @@ class MockTracker { | |||
| 652 | 652 | if (format) { // Format is not yet known for ambiguous files when detection is enabled. | |
| 653 | 653 | validateOneOf(format, 'format', kSupportedFormats); | |
| 654 | 654 | } | |
| 655 | - const baseURL = URL.parse(url); | ||
| 655 | + const baseURL = URLParse(url); | ||
| 656 | 656 | ||
| 657 | 657 | if (!baseURL) { | |
| 658 | 658 | throw new ERR_INVALID_ARG_VALUE( | |
0 commit comments