Commit d8f8719
committed
build: do not pass mode option to test-v8 command
It was removed upstream and is now inferred from the build config.
PR-URL: #35705
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #38275
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>1 parent 329ee8b commit d8f8719
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -648,8 +648,7 @@ test-with-async-hooks: | |||
| 648 | 648 | ifneq ("","$(wildcard deps/v8/tools/run-tests.py)") | |
| 649 | 649 | # Related CI job: node-test-commit-v8-linux | |
| 650 | 650 | test-v8: v8 ## Runs the V8 test suite on deps/v8. | |
| 651 | - deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \ | ||
| 652 | - --mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) \ | ||
| 651 | + deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) $(V8_TEST_OPTIONS) \ | ||
| 653 | 652 | mjsunit cctest debugger inspector message preparser \ | |
| 654 | 653 | $(TAP_V8) | |
| 655 | 654 | $(info Testing hash seed) | |
0 commit comments