Commit d96a97a
module: make synthetic module evaluation steps return a Promise to support top level await
Top level await expects that all module script evaluation returns a
Promise. As such, update
ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a
resolved Promise now that V8 has enabled top-level await by default.
Unfortunately I don't have a spec reference that I can point to here
because the Built-in modules proposal isn't yet updated for
top level await.
The corresponding change for Blink is
https://chromium-review.googlesource.com/c/chromium/src/+/2568823.
This will allow a workaround for Node in this V8 bugfix to be removed:
https://chromium-review.googlesource.com/c/v8/v8/+/2673794.
Fixes: #37299
PR-URL: #37300
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>1 parent 7d8fd3f commit d96a97a
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -665,7 +665,14 @@ MaybeLocal<Value> ModuleWrap::SyntheticModuleEvaluationStepsCallback( | |||
| 665 | 665 | try_catch.ReThrow(); | |
| 666 | 666 | return MaybeLocal<Value>(); | |
| 667 | 667 | } | |
| 668 | - return Undefined(isolate); | ||
| 668 | + | ||
| 669 | + Local<Promise::Resolver> resolver; | ||
| 670 | + if (!Promise::Resolver::New(context).ToLocal(&resolver)) { | ||
| 671 | + return MaybeLocal<Value>(); | ||
| 672 | + } | ||
| 673 | + | ||
| 674 | + resolver->Resolve(context, Undefined(isolate)).ToChecked(); | ||
| 675 | + return resolver->GetPromise(); | ||
| 669 | 676 | } | |
| 670 | 677 | ||
| 671 | 678 | void ModuleWrap::SetSyntheticExport(const FunctionCallbackInfo<Value>& args) { | |
0 commit comments