tools: disable trap handler for Windows cross-compiler · nodejs/node@d97ad30 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d97ad30

Browse filesBrowse the repository at this point in the historyBrowse files

targos

committed

tools: disable trap handler for Windows cross-compiler

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent e3f8988 commit d97ad30
Copy full SHA for d97ad30

1 file changed

+6-3Lines changed: 6 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tools/v8_gypfiles
  • v8.gyp

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tools/v8_gypfiles/v8.gyp‎

Copy file name to clipboardExpand all lines: tools/v8_gypfiles/v8.gyp

+6-3Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -602,7 +602,8 @@
602	602	'<(V8_ROOT)/src/trap-handler/handler-inside-posix.h',
603	603	],
604	604	}],
605		- ['_toolset=="host" and host_arch=="x64" and (OS=="linux" or OS=="mac" or OS=="win")', {
	605	+ # TODO(targos): Replace False with OS=="win" if handler-outside-simulator.cc becomes compatible with MSVC.
	606	+ ['_toolset=="host" and host_arch=="x64" and (OS=="linux" or OS=="mac" or False)', {
606	607	'sources': [
607	608	'<(V8_ROOT)/src/trap-handler/trap-handler-simulator.h',
608	609	],
@@ -822,13 +823,15 @@
822	823	'<(V8_ROOT)/src/trap-handler/handler-outside-posix.cc',
823	824	],
824	825	}],
825		- ['_toolset=="host" and host_arch=="x64" and OS=="win"', {
	826	+ # TODO(targos): Replace False with OS=="win" if handler-outside-simulator.cc becomes compatible with MSVC.
	827	+ ['_toolset=="host" and host_arch=="x64" and False', {
826	828	'sources': [
827	829	'<(V8_ROOT)/src/trap-handler/handler-inside-win.cc',
828	830	'<(V8_ROOT)/src/trap-handler/handler-outside-win.cc',
829	831	],
830	832	}],
831		- ['_toolset=="host" and host_arch=="x64" and (OS=="linux" or OS=="mac" or OS=="win")', {
	833	+ # TODO(targos): Replace False with OS=="win" if handler-outside-simulator.cc becomes compatible with MSVC.
	834	+ ['_toolset=="host" and host_arch=="x64" and (OS=="linux" or OS=="mac" or False)', {
832	835	'sources': [
833	836	'<(V8_ROOT)/src/trap-handler/handler-outside-simulator.cc',
834	837	],

0 commit comments

Comments

0 (0)