Commit d9a1d78
build: consolidate JS and md linting GitHub Actions
Linting markdown runs the JavaScript linting job, so consolidate them to
conserve time and resources. Run JavaScript separately, but then run
markdown linting so it can use the cached results of the JavaScript
linting.
PR-URL: #42572
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent beffed1 commit d9a1d78
1 file changed
Lines changed: 4 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -49,7 +49,7 @@ jobs: | |||
| 49 | 49 | run: npx envinfo | |
| 50 | 50 | - name: Lint C/C++ files | |
| 51 | 51 | run: make lint-cpp | |
| 52 | - lint-md: | ||
| 52 | + lint-js-and-md: | ||
| 53 | 53 | if: github.event.pull_request.draft == false | |
| 54 | 54 | runs-on: ubuntu-latest | |
| 55 | 55 | steps: | |
@@ -62,32 +62,18 @@ jobs: | |||
| 62 | 62 | node-version: ${{ env.NODE_VERSION }} | |
| 63 | 63 | - name: Environment Information | |
| 64 | 64 | run: npx envinfo | |
| 65 | + - name: Lint JavaScript files | ||
| 66 | + run: NODE=$(command -v node) make lint-js | ||
| 65 | 67 | - name: Get release version numbers | |
| 66 | 68 | if: ${{ github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }} | |
| 67 | 69 | id: get-released-versions | |
| 68 | 70 | run: ./tools/lint-md/list-released-versions-from-changelogs.mjs | |
| 69 | - - name: Lint docs | ||
| 71 | + - name: Lint markdown files | ||
| 70 | 72 | run: | | |
| 71 | 73 | echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json" | |
| 72 | 74 | NODE=$(command -v node) make lint-md | |
| 73 | 75 | env: | |
| 74 | 76 | NODE_RELEASED_VERSIONS: ${{ steps.get-released-versions.outputs.NODE_RELEASED_VERSIONS }} | |
| 75 | - | ||
| 76 | - lint-js: | ||
| 77 | - if: github.event.pull_request.draft == false | ||
| 78 | - runs-on: ubuntu-latest | ||
| 79 | - steps: | ||
| 80 | - - uses: actions/checkout@v3 | ||
| 81 | - with: | ||
| 82 | - persist-credentials: false | ||
| 83 | - - name: Use Node.js ${{ env.NODE_VERSION }} | ||
| 84 | - uses: actions/setup-node@v3 | ||
| 85 | - with: | ||
| 86 | - node-version: ${{ env.NODE_VERSION }} | ||
| 87 | - - name: Environment Information | ||
| 88 | - run: npx envinfo | ||
| 89 | - - name: Lint JavaScript files | ||
| 90 | - run: NODE=$(command -v node) make lint-js | ||
| 91 | 77 | lint-py: | |
| 92 | 78 | if: github.event.pull_request.draft == false | |
| 93 | 79 | runs-on: ubuntu-latest | |
0 commit comments