Commit d9e9d9f
deps: backport e7cc609 from upstream V8
This is part 1/2 of the fixes from v8:4871. This fixes a segfault in
verify-heap.
Original commit message:
[crankshaft] Write fillers for folded old space allocations during verify-heap
If we don't write fillers, we crash during PagedSpace verification when we try
to iterate over dead memory (unused folded allocation slots).
BUG=v8:4871,chromium:580959
LOG=N
Review URL: https://codereview.chromium.org/1837163002
Cr-Commit-Position: refs/heads/master@{#35097}
Fixes: #5900
V8-Bug: https://bugs.chromium.org/p/v8/issues/detail?id=4871
PR-URL: #7303
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>1 parent 5782ec2 commit d9e9d9f
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3825,12 +3825,12 @@ bool HAllocate::HandleSideEffectDominator(GVNFlag side_effect, | |||
| 3825 | 3825 | } | |
| 3826 | 3826 | } | |
| 3827 | 3827 | ||
| 3828 | - bool keep_new_space_iterable = FLAG_log_gc || FLAG_heap_stats; | ||
| 3828 | + bool keep_heap_iterable = FLAG_log_gc || FLAG_heap_stats; | ||
| 3829 | 3829 | #ifdef VERIFY_HEAP | |
| 3830 | - keep_new_space_iterable = keep_new_space_iterable || FLAG_verify_heap; | ||
| 3830 | + keep_heap_iterable = keep_heap_iterable || FLAG_verify_heap; | ||
| 3831 | 3831 | #endif | |
| 3832 | 3832 | ||
| 3833 | - if (keep_new_space_iterable && dominator_allocate->IsNewSpaceAllocation()) { | ||
| 3833 | + if (keep_heap_iterable) { | ||
| 3834 | 3834 | dominator_allocate->MakePrefillWithFiller(); | |
| 3835 | 3835 | } else { | |
| 3836 | 3836 | // TODO(hpayer): This is a short-term hack to make allocation mementos | |
0 commit comments