Commit da44c2c
test: rename test-regress-GH-1697
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure
Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
PR-URL: #19161
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>1 parent fa43d2f commit da44c2c
1 file changed
Lines changed: 5 additions & 0 deletions
test/sequential/test-regress-GH-1697.js renamed to test/sequential/test-regress-net-response_size.js
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -21,6 +21,11 @@ | |||
| 21 | 21 | ||
| 22 | 22 | 'use strict'; | |
| 23 | 23 | const common = require('../common'); | |
| 24 | + | ||
| 25 | + // Make sure the net module's server doesn't throw an error when handling | ||
| 26 | + // responses that are either too long or too small (especially on windows) | ||
| 27 | + // https://github.com/nodejs/node-v0.x-archive/issues/1697 | ||
| 28 | + | ||
| 24 | 29 | const net = require('net'); | |
| 25 | 30 | const cp = require('child_process'); | |
| 26 | 31 | ||
0 commit comments