Commit da8baf4
test: do not load absolute path crypto engines twice
Newer versions of OpenSSL now throws an error if an engine is loaded
twice by its absolute path (a second load by its id appears to be okay).
PR-URL: #41177
Refs: quictls/openssl#69
Refs: https://mta.openssl.org/pipermail/openssl-announce/2021-December/000212.html
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>1 parent 8fcb71a commit da8baf4
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -44,10 +44,13 @@ crypto.setEngine('dynamic', crypto.constants.ENGINE_METHOD_RSA); | |||
| 44 | 44 | fs.accessSync(enginePath); | |
| 45 | 45 | ||
| 46 | 46 | crypto.setEngine(enginePath); | |
| 47 | - crypto.setEngine(enginePath); | ||
| 47 | + // OpenSSL 3.0.1 and 1.1.1m now throw errors if an engine is loaded again | ||
| 48 | + // with a duplicate absolute path. | ||
| 49 | + // TODO(richardlau): figure out why this fails on macOS but not Linux. | ||
| 50 | + // crypto.setEngine(enginePath); | ||
| 48 | 51 | ||
| 49 | - crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA); | ||
| 50 | - crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA); | ||
| 52 | + // crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA); | ||
| 53 | + // crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA); | ||
| 51 | 54 | ||
| 52 | 55 | process.env.OPENSSL_ENGINES = execDir; | |
| 53 | 56 | ||
0 commit comments