Commit dab64bb
worker: spin uv_run twice before closing loop
On Windows, the Platform’s `uv_async_t` may need two iterations
before closing when it was previously in use.
Refs: #26089
Refs: #26006
PR-URL: #26138
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>1 parent d550de4 commit dab64bb
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -150,7 +150,10 @@ class WorkerThreadData { | |||
| 150 | 150 | ||
| 151 | 151 | isolate->Dispose(); | |
| 152 | 152 | ||
| 153 | - // Need to run the loop one more time to close the platform's uv_async_t | ||
| 153 | + // Need to run the loop twice more to close the platform's uv_async_t | ||
| 154 | + // TODO(addaleax): It would be better for the platform itself to provide | ||
| 155 | + // some kind of notification when it has fully cleaned up. | ||
| 156 | + uv_run(&loop_, UV_RUN_ONCE); | ||
| 154 | 157 | uv_run(&loop_, UV_RUN_ONCE); | |
| 155 | 158 | ||
| 156 | 159 | CheckedUvLoopClose(&loop_); | |
0 commit comments