test: use`mustSucceed` instead of `mustCall` with `assert.ifError` · nodejs/node@db1d714 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit db1d714

Browse filesBrowse the repository at this point in the historyBrowse files

fossamagna

authored and

juanarbol

committed

test: usemustSucceed instead of mustCall with assert.ifError

PR-URL: #42806 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

1 parent 8bb7f56 commit db1d714
Copy full SHA for db1d714

1 file changed

+2-4Lines changed: 2 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-fs-opendir.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-fs-opendir.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-opendir.js

+2-4Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -67,18 +67,16 @@ const invalidCallbackObj = {
67	67	// Check the opendir async version
68	68	fs.opendir(testDir, common.mustSucceed((dir) => {
69	69	let sync = true;
70		- dir.read(common.mustCall((err, dirent) => {
	70	+ dir.read(common.mustSucceed((dirent) => {
71	71	assert(!sync);
72		- assert.ifError(err);
73	72
74	73	// Order is operating / file system dependent
75	74	assert(files.includes(dirent.name), `'files' should include ${dirent}`);
76	75	assertDirent(dirent);
77	76
78	77	let syncInner = true;
79		- dir.read(common.mustCall((err, dirent) => {
	78	+ dir.read(common.mustSucceed((dirent) => {
80	79	assert(!syncInner);
81		- assert.ifError(err);
82	80
83	81	dir.close(common.mustSucceed());
84	82	}));

0 commit comments

Comments

0 (0)