Commit dc766e6
src: fix handle leak in BuildStatsObject()
Create a handle scope before performing a check that creates a handle,
otherwise the handle is leaked into the handle scope of the caller.
PR-URL: #7711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>1 parent 96882e1 commit dc766e6
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -420,11 +420,11 @@ static void Close(const FunctionCallbackInfo<Value>& args) { | |||
| 420 | 420 | ||
| 421 | 421 | ||
| 422 | 422 | Local<Value> BuildStatsObject(Environment* env, const uv_stat_t* s) { | |
| 423 | + EscapableHandleScope handle_scope(env->isolate()); | ||
| 424 | + | ||
| 423 | 425 | // If you hit this assertion, you forgot to enter the v8::Context first. | |
| 424 | 426 | CHECK_EQ(env->context(), env->isolate()->GetCurrentContext()); | |
| 425 | 427 | ||
| 426 | - EscapableHandleScope handle_scope(env->isolate()); | ||
| 427 | - | ||
| 428 | 428 | // The code below is very nasty-looking but it prevents a segmentation fault | |
| 429 | 429 | // when people run JS code like the snippet below. It's apparently more | |
| 430 | 430 | // common than you would expect, several people have reported this crash... | |
0 commit comments