stream: fix the ReadableStreamBYOBReader error message · nodejs/node@dc99ae3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit dc99ae3

Browse filesBrowse the repository at this point in the historyBrowse files

jasnell

authored and

targos

committed

stream: fix the ReadableStreamBYOBReader error message

PR-URL: #40846 Reviewed-By: Robert Nagy <ronagy@icloud.com>

1 parent 65b33ba commit dc99ae3
Copy full SHA for dc99ae3

2 files changed

+7-3Lines changed: 7 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/webstreams
  • readablestream.js
• test/parallel
  • test-whatwg-readablestream.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/webstreams/readablestream.js‎

Copy file name to clipboardExpand all lines: lib/internal/webstreams/readablestream.js

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -508,6 +508,8 @@ class ReadableStream {
508	508	return customInspect(depth, options, this[kType], {
509	509	locked: this.locked,
510	510	state: this[kState].state,
	511	+ supportsBYOB:
	512	+ this[kState].controller instanceof ReadableByteStreamController,
511	513	});
512	514	}
513	515
@@ -1745,7 +1747,7 @@ function setupReadableStreamBYOBReader(reader, stream) {
1745	1747	controller,
1746	1748	} = stream[kState];
1747	1749	if (!isReadableByteStreamController(controller))
1748		- throw new ERR_INVALID_ARG_VALUE('reader', reader, 'must be a byte stream');
	1750	+ throw new ERR_INVALID_ARG_VALUE('stream', stream, 'must be a byte stream');
1749	1751	readableStreamReaderGenericInitialize(reader, stream);
1750	1752	reader[kState].readIntoRequests = [];
1751	1753	}

Collapse file

‎test/parallel/test-whatwg-readablestream.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-whatwg-readablestream.js

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1410,10 +1410,12 @@ class Source {
1410	1410
1411	1411	assert.strictEqual(
1412	1412	inspect(readable),
1413		- 'ReadableStream { locked: false, state: \'readable\' }');
	1413	+ 'ReadableStream { locked: false, state: \'readable\', ' +
	1414	+ 'supportsBYOB: false }');
1414	1415	assert.strictEqual(
1415	1416	inspect(readable, { depth: null }),
1416		- 'ReadableStream { locked: false, state: \'readable\' }');
	1417	+ 'ReadableStream { locked: false, state: \'readable\', ' +
	1418	+ 'supportsBYOB: false }');
1417	1419	assert.strictEqual(
1418	1420	inspect(readable, { depth: 0 }),
1419	1421	'ReadableStream [Object]');

0 commit comments

Comments

0 (0)