Commit dca5ac1
deps: suppress zlib compiler warnings
Currently, there are a number of compilation warnings from zlib like the
following one:
../deps/zlib/infback.c: In function ‘inflateBack’:
../deps/zlib/infback.c:479:25: warning:
this statement may fall through [-Wimplicit-fallthrough=]
479 | state->mode = LEN;
| ~~~~~~~~~~~~^~~~~
../deps/zlib/infback.c:481:9: note: here
481 | case LEN:
| ^~~~
In this case there is no break statement and the intention is to fall
through:
Tracev((stderr, "inflate: codes ok\n"));
state->mode = LEN;
case LEN:
This commit adds -Wno-implicit-fallthrough' to zlib.gyp to suppress
these warnings.
PR-URL: #40343
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 91c3bf6 commit dca5ac1
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -54,6 +54,7 @@ | |||
| 54 | 54 | 'conditions': [ | |
| 55 | 55 | ['OS!="win"', { | |
| 56 | 56 | 'cflags!': [ '-ansi' ], | |
| 57 | + 'cflags': [ '-Wno-implicit-fallthrough' ], | ||
| 57 | 58 | 'defines': [ 'HAVE_HIDDEN' ], | |
| 58 | 59 | }], | |
| 59 | 60 | ['OS=="mac" or OS=="ios" or OS=="freebsd" or OS=="android"', { | |
0 commit comments