Commit dcae032
buffer: remove TODOs in atob / btoa
Refs: #38433 (comment)
PR-URL: #38548
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent 90b640e commit dcae032
1 file changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1217,8 +1217,9 @@ const lazyInvalidCharError = hideStackFrames((message, name) => { | |||
| 1217 | 1217 | }); | |
| 1218 | 1218 | ||
| 1219 | 1219 | function btoa(input) { | |
| 1220 | - // TODO(@jasnell): The implementation here has not been performance | ||
| 1221 | - // optimized in any way. | ||
| 1220 | + // The implementation here has not been performance optimized in any way and | ||
| 1221 | + // should not be. | ||
| 1222 | + // Refs: https://github.com/nodejs/node/pull/38433#issuecomment-828426932 | ||
| 1222 | 1223 | input = `${input}`; | |
| 1223 | 1224 | for (let n = 0; n < input.length; n++) { | |
| 1224 | 1225 | if (input[n].charCodeAt(0) > 0xff) | |
@@ -1232,8 +1233,9 @@ const kBase64Digits = | |||
| 1232 | 1233 | 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/='; | |
| 1233 | 1234 | ||
| 1234 | 1235 | function atob(input) { | |
| 1235 | - // TODO(@jasnell): The implementation here has not been performance | ||
| 1236 | - // optimized in any way. | ||
| 1236 | + // The implementation here has not been performance optimized in any way and | ||
| 1237 | + // should not be. | ||
| 1238 | + // Refs: https://github.com/nodejs/node/pull/38433#issuecomment-828426932 | ||
| 1237 | 1239 | input = `${input}`; | |
| 1238 | 1240 | for (let n = 0; n < input.length; n++) { | |
| 1239 | 1241 | if (!kBase64Digits.includes(input[n])) | |
0 commit comments