test: do not use fixed port in async-hooks/test-httparser-reuse · nodejs/node@dce4947 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit dce4947

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

targos

committed

test: do not use fixed port in async-hooks/test-httparser-reuse

Otherwise this was failing on machines which already had a service running on port 3000. PR-URL: #28312 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 21d2bdd commit dce4947
Copy full SHA for dce4947

1 file changed

+3-4Lines changed: 3 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/async-hooks
  • test-httparser-reuse.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/async-hooks/test-httparser-reuse.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-httparser-reuse.js

+3-4Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -47,10 +47,9 @@ const server = http.createServer((req, res) => {
47	47	res.end();
48	48	});
49	49
50		- const PORT = 3000;
51		- const url = `http://127.0.0.1:${PORT}`;
52		-
53		- server.listen(PORT, common.mustCall(() => {
	50	+ server.listen(0, common.mustCall(() => {
	51	+ const PORT = server.address().port;
	52	+ const url = `http://127.0.0.1:${PORT}`;
54	53	http.get(url, common.mustCall(() => {
55	54	server.close(common.mustCall(() => {
56	55	server.listen(PORT, common.mustCall(() => {

0 commit comments

Comments

0 (0)