test: fix test-bootstrap-modules for coverage generation · nodejs/node@dd0f164 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit dd0f164

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

richardlau

committed

test: fix test-bootstrap-modules for coverage generation

The internal binding profiler is loaded if the test is run with NODE_V8_COVERAGE. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

1 parent 587e70e commit dd0f164
Copy full SHA for dd0f164

1 file changed

+5Lines changed: 5 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-bootstrap-modules.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-bootstrap-modules.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-bootstrap-modules.js

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -160,6 +160,11 @@ if (process.features.inspector) {
160	160	expected.beforePreExec.add('Internal Binding inspector');
161	161	expected.beforePreExec.add('NativeModule internal/util/inspector');
162	162	expected.atRunTime.add('NativeModule internal/inspector_async_hook');
	163	+
	164	+ // This is loaded if the test is run with NODE_V8_COVERAGE.
	165	+ if (process.env.NODE_V8_COVERAGE) {
	166	+ expected.atRunTime.add('Internal Binding profiler');
	167	+ }
163	168	}
164	169
165	170	const difference = (setA, setB) => {

0 commit comments

Comments

0 (0)