Commit ddb7df7
test: deflake test-http2-empty-frame-without-eof
It may happen that the data in `emptyframe.http2` reaches the client
even before the client has started sending the request, causing an
`ERR_HTTP2_STREAM_ERROR` instead. Fix this by making sure the frame is
not sent until some data reaches the server.
PR-URL: #45212
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent d9163f1 commit ddb7df7
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -10,7 +10,9 @@ const { once } = require('events'); | |||
| 10 | 10 | async function main() { | |
| 11 | 11 | const blobWithEmptyFrame = readSync('emptyframe.http2'); | |
| 12 | 12 | const server = net.createServer((socket) => { | |
| 13 | - socket.end(blobWithEmptyFrame); | ||
| 13 | + socket.once('data', () => { | ||
| 14 | + socket.end(blobWithEmptyFrame); | ||
| 15 | + }); | ||
| 14 | 16 | }).listen(0); | |
| 15 | 17 | await once(server, 'listening'); | |
| 16 | 18 | ||
0 commit comments