Commit de46a34
test: skip test-diagnostics-channel-memory-leak.js
There is currently no reliable way to detect this leak because:
1. We cannot reliably get a reference to the channel from the
API to detect finalization without creating another strong reference.
2. This test does gc() and then checks memory usage - however the
use of gc() disables code aging which can actually lead to increased
memory usage overall, as it is not intended to be used to lower
memory usage in the first place.
3. The implementation of diagnostics channels relies on ephemeron gc
which is inefficient, it's not reliable to use the typical "create
a lot of objects and see if it crashes" trick to check leaks.
Skip the test for now until we find a way to test it reliably.
To avoid flakiness in the CI, it's better to remove an unreliable
test altogether.
PR-URL: #50327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>1 parent 8487cac commit de46a34
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,6 +5,9 @@ prefix parallel | |||
| 5 | 5 | # sample-test : PASS,FLAKY | |
| 6 | 6 | ||
| 7 | 7 | [true] # This section applies to all platforms | |
| 8 | + # https://github.com/nodejs/node/pull/50327 | ||
| 9 | + # Currently there's no reliable way to test it. | ||
| 10 | + test-diagnostics-channel-memory-leak: SKIP | ||
| 8 | 11 | ||
| 9 | 12 | [$system==win32] | |
| 10 | 13 | # https://github.com/nodejs/node/issues/41206 | |
0 commit comments