Commit df05ddf
src: refactor deprecated v8::Function::Call call
Refs: #23414 (comment)
PR-URL: #23804
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent ab58439 commit df05ddf
1 file changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1381,9 +1381,8 @@ void FatalException(Isolate* isolate, | |||
| 1381 | 1381 | fatal_try_catch.SetVerbose(false); | |
| 1382 | 1382 | ||
| 1383 | 1383 | // This will return true if the JS layer handled it, false otherwise | |
| 1384 | - Local<Value> caught = | ||
| 1385 | - fatal_exception_function.As<Function>() | ||
| 1386 | - ->Call(process_object, 1, &error); | ||
| 1384 | + MaybeLocal<Value> caught = fatal_exception_function.As<Function>()->Call( | ||
| 1385 | + env->context(), process_object, 1, &error); | ||
| 1387 | 1386 | ||
| 1388 | 1387 | if (fatal_try_catch.HasTerminated()) | |
| 1389 | 1388 | return; | |
@@ -1392,7 +1391,7 @@ void FatalException(Isolate* isolate, | |||
| 1392 | 1391 | // The fatal exception function threw, so we must exit | |
| 1393 | 1392 | ReportException(env, fatal_try_catch); | |
| 1394 | 1393 | exit(7); | |
| 1395 | - } else if (caught->IsFalse()) { | ||
| 1394 | + } else if (caught.ToLocalChecked()->IsFalse()) { | ||
| 1396 | 1395 | ReportException(env, error, message); | |
| 1397 | 1396 | ||
| 1398 | 1397 | // fatal_exception_function call before may have set a new exit code -> | |
0 commit comments