| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent 2be863b commit df16f0f
3 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2705,6 +2705,9 @@ Node.js versions. | |||
| 2705 | 2705 | ||
| 2706 | 2706 | <!-- YAML | |
| 2707 | 2707 | changes: | |
| 2708 | + - version: REPLACEME | ||
| 2709 | + pr-url: https://github.com/nodejs/node/pull/58527 | ||
| 2710 | + description: End-of-Life. | ||
| 2708 | 2711 | - version: v13.0.0 | |
| 2709 | 2712 | pr-url: https://github.com/nodejs/node/pull/27949 | |
| 2710 | 2713 | description: Runtime deprecation. | |
@@ -2713,7 +2716,7 @@ changes: | |||
| 2713 | 2716 | description: Documentation-only. | |
| 2714 | 2717 | --> | |
| 2715 | 2718 | ||
| 2716 | - Type: Runtime | ||
| 2719 | + Type: End-of-Life | ||
| 2717 | 2720 | ||
| 2718 | 2721 | The `_channel` property of child process objects returned by `spawn()` and | |
| 2719 | 2722 | similar functions is not intended for public use. Use `ChildProcess.channel` | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,7 +7,6 @@ const { | |||
| 7 | 7 | ArrayPrototypeSlice, | |
| 8 | 8 | FunctionPrototype, | |
| 9 | 9 | FunctionPrototypeCall, | |
| 10 | - ObjectDefineProperty, | ||
| 11 | 10 | ObjectSetPrototypeOf, | |
| 12 | 11 | ReflectApply, | |
| 13 | 12 | StringPrototypeSlice, | |
@@ -56,7 +55,7 @@ const { TTY } = internalBinding('tty_wrap'); | |||
| 56 | 55 | const { UDP } = internalBinding('udp_wrap'); | |
| 57 | 56 | const SocketList = require('internal/socket_list'); | |
| 58 | 57 | const { owner_symbol } = require('internal/async_hooks').symbols; | |
| 59 | - const { convertToValidSignal, deprecate } = require('internal/util'); | ||
| 58 | + const { convertToValidSignal } = require('internal/util'); | ||
| 60 | 59 | const { isArrayBufferView } = require('internal/util/types'); | |
| 61 | 60 | const spawn_sync = internalBinding('spawn_sync'); | |
| 62 | 61 | const { kStateSymbol } = require('internal/dgram'); | |
@@ -575,27 +574,12 @@ class Control extends EventEmitter { | |||
| 575 | 574 | } | |
| 576 | 575 | } | |
| 577 | 576 | ||
| 578 | - const channelDeprecationMsg = '_channel is deprecated. ' + | ||
| 579 | - 'Use ChildProcess.channel instead.'; | ||
| 580 | - | ||
| 581 | 577 | let serialization; | |
| 582 | 578 | function setupChannel(target, channel, serializationMode) { | |
| 583 | 579 | const control = new Control(channel); | |
| 584 | 580 | target.channel = control; | |
| 585 | 581 | target[kChannelHandle] = channel; | |
| 586 | 582 | ||
| 587 | - ObjectDefineProperty(target, '_channel', { | ||
| 588 | - __proto__: null, | ||
| 589 | - get: deprecate(() => { | ||
| 590 | - return target.channel; | ||
| 591 | - }, channelDeprecationMsg, 'DEP0129'), | ||
| 592 | - set: deprecate((val) => { | ||
| 593 | - target.channel = val; | ||
| 594 | - }, channelDeprecationMsg, 'DEP0129'), | ||
| 595 | - configurable: true, | ||
| 596 | - enumerable: false, | ||
| 597 | - }); | ||
| 598 | - | ||
| 599 | 583 | target._handleQueue = null; | |
| 600 | 584 | target._pendingMessage = null; | |
| 601 | 585 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,7 +18,6 @@ | |||
| 18 | 18 | // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | |
| 19 | 19 | // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | |
| 20 | 20 | // USE OR OTHER DEALINGS IN THE SOFTWARE. | |
| 21 | - // Flags: --no-warnings | ||
| 22 | 21 | 'use strict'; | |
| 23 | 22 | const common = require('../common'); | |
| 24 | 23 | const assert = require('assert'); | |
@@ -29,7 +28,6 @@ const debug = require('util').debuglog('test'); | |||
| 29 | 28 | ||
| 30 | 29 | const n = fork(fixtures.path('child-process-spawn-node.js'), args); | |
| 31 | 30 | ||
| 32 | - assert.strictEqual(n.channel, n._channel); | ||
| 33 | 31 | assert.deepStrictEqual(args, ['foo', 'bar']); | |
| 34 | 32 | ||
| 35 | 33 | n.on('message', (m) => { | |
| Back | FazBrowse Home | New Git URL |
0 commit comments